[webkit-reviews] review granted: [Bug 66366] [EFL] Private function _ewk_view_viewport_attributes_compute takes an internal data of ewk_view. : [Attachment 111960] updated patch to a new coding style of WebKit-EFL

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Grzegorz
<g.czajkowski at samsung.com>'s request for review:
Bug 66366: [EFL] Private function _ewk_view_viewport_attributes_compute takes
an internal data of ewk_view.
https://bugs.webkit.org/show_bug.cgi?id=66366

Attachment 111960: updated patch to a new coding style of WebKit-EFL
https://bugs.webkit.org/attachment.cgi?id=111960&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111960&action=review


> Source/WebKit/efl/ChangeLog:9
> +	   Passes to _ewk_view_viewport_attributes_compute an internal
> +	   data of ewk_view instead of the view object.

This can fit in one line.

> Source/WebKit/efl/ChangeLog:11
> +	   Adds to ewk_view_viewport_attributes_get NULL checks to
> +	   avoid unexpected results since this is API.

Ditto.