[webkit-reviews] review granted: [Bug 70650] Add chromium bridging for MediaPlayer::setAudioSource() method so we can know audio stream format : [Attachment 112286] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 70650: Add chromium bridging for MediaPlayer::setAudioSource() method so we
can know audio stream format
https://bugs.webkit.org/show_bug.cgi?id=70650

Attachment 112286: Patch
https://bugs.webkit.org/attachment.cgi?id=112286&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112286&action=review


> Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:673
> +    m_webAudioSourceProvider = provider;

before replacing m_webAudioSourceProvider, should we perhaps null out the
client
of the existing provider?

  if (m_webAudioSourceProvider)
      m_webAudioSourceProvider->setClient(0);
  m_webAudioSourceProvider = provider;
  if (m_webAudioSourceProvider)
      m_webAudioSourceProvider->setClient(&m_client);

This way we don't have to worry about the old provider holding a pointer back
to m_client.

> Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp:678
> +void
WebMediaPlayerClientImpl::AudioSourceProviderImpl::setClient(WebCore::AudioSour
ceProviderClient* client)

nit: it looks like you can drop the WebCore:: prefixes in this file.

R=me otherwise.