[webkit-reviews] review denied: [Bug 70836] [chromium] add swapOut method to WebFrame : [Attachment 112395] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Karl Koscher
<supersat at chromium.org>'s request for review:
Bug 70836: [chromium] add swapOut method to WebFrame
https://bugs.webkit.org/show_bug.cgi?id=70836

Attachment 112395: Patch
https://bugs.webkit.org/attachment.cgi?id=112395&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112395&action=review


> Source/WebKit/chromium/src/WebFrameImpl.cpp:1059
> +void WebFrameImpl::swapOut()

I think this function belongs in the Chromium repository instead.  We should
just
expose the necessary primitives through the WebKit API here.  For example, I
think
it makes sense to have a WebDocument::create() function and a
WebFrame::setDocument
function.  Perhaps WebFrame::setDocument can call m_frame->loader()->clear()
before
changing the document?

Basically, the concept of "swapping out" doesn't belong in WebKit.