[webkit-reviews] review granted: [Bug 70714] [chromium] Encapsulate state machine parts of scheduling in CCSchedulerStateMachine : [Attachment 112448] input enum -> real functions

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Nat Duca
<nduca at chromium.org>'s request for review:
Bug 70714: [chromium] Encapsulate state machine parts of scheduling in
CCSchedulerStateMachine
https://bugs.webkit.org/show_bug.cgi?id=70714

Attachment 112448: input enum -> real functions
https://bugs.webkit.org/attachment.cgi?id=112448&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112448&action=review


R=me, remaining nits are up to you

> Source/WebCore/platform/graphics/chromium/cc/CCSchedulerStateMachine.h:43
> +	       : m_commitState(COMMIT_STATE_IDLE)

odd indentation - the : should be 4 spaces in from the previous line. Could you
move the c'tor to the .cpp? there's a whole lotta lines to read here before we
get to the API bits that a user of this class would be interested in

> Source/WebKit/chromium/tests/CCSchedulerStateMachineTest.cpp:180
> +TEST(CCSchedulerStateMachineTest, TestSetNeedsCommitIsntLost)

IsntLost->IsNotLost ? looks like a typo without the apostrophe (although you
obviously can't put that in the function name)