[webkit-reviews] review denied: [Bug 70390] WebKit not ensure font load before calling Skia devices to draw during Chrome printing : [Attachment 112423] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 25 16:23:50 PDT 2011
James Robinson <jamesr at chromium.org> has denied Arthur Hsu
<arthurhsu at chromium.org>'s request for review:
Bug 70390: WebKit not ensure font load before calling Skia devices to draw
during Chrome printing
https://bugs.webkit.org/show_bug.cgi?id=70390
Attachment 112423: Patch
https://bugs.webkit.org/attachment.cgi?id=112423&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
You should know by now what I'm going to ask:
1.) What is the performance impact?
2.) This appears to be code that's used in the printing and non-printing
codepaths. What is the correctness impact for the non-printing case and how can
we test that?
R- until these issues are resolved.
More information about the webkit-reviews
mailing list