[webkit-reviews] review granted: [Bug 70852] Setting up a HiDPI base-level GraphicsContext should be more straightforward for WebKit2 : [Attachment 112412] Another patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Beth Dakin <bdakin at apple.com>'s request for review:
Bug 70852: Setting up a HiDPI base-level GraphicsContext should be more
straightforward for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=70852

Attachment 112412: Another patch
https://bugs.webkit.org/attachment.cgi?id=112412&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=112412&action=review


> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:1597
> +    scale(FloatSize(deviceScaleFactor, deviceScaleFactor));

A slightly neater way to do this would be to keep this common part in the
cross-platform applyDeviceScaleFactor() and have that one call a private
platformApplyDeviceScaleFactor() that would have a no-op definition in
GraphicsContext.cpp and a CG-specific definition in GraphicsContextCG.cpp, but
I think this is okay for now.