[webkit-reviews] review denied: [Bug 70846] Flesh out WKBrowsingContextLoadDelegate a bit : [Attachment 112394] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has denied Sam Weinig <sam at webkit.org>'s
request for review:
Bug 70846: Flesh out WKBrowsingContextLoadDelegate a bit
https://bugs.webkit.org/show_bug.cgi?id=70846

Attachment 112394: Patch
https://bugs.webkit.org/attachment.cgi?id=112394&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=112394&action=review


> Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm:218
> +    WKBrowsingContextController *browsingContext =
(WKBrowsingContextController *)clientInfo;
> +    [browsingContext.loadDelegate
browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:browsingCon
text];
> +}

This does not check that the delegate responds to the selector. The code needs
to do that, and possibly cache the result as well.

> Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm:257
> +    WKBrowsingContextController *browsingContext =
(WKBrowsingContextController *)clientInfo;
> +    [browsingContext.loadDelegate
browsingContextControllerDidFailLoad:browsingContext withError:(NSError
*)cfError.get()];

Ditto.