[webkit-reviews] review denied: [Bug 70733] [CSSRegions]Flag regions with custom styling : [Attachment 112218] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Mihnea Ovidenie <mihnea at adobe.com>'s
request for review:
Bug 70733: [CSSRegions]Flag regions with custom styling
https://bugs.webkit.org/show_bug.cgi?id=70733

Attachment 112218: Patch
https://bugs.webkit.org/attachment.cgi?id=112218&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I think a better approach is to store the flag in the RenderRegion itself. If
you subclass styleDidChange, you could check the RenderStyle at that time. Then
you don't have to add isRegionDisplayType(), etc., since we know we made a
RenderRegion already.

Basically in RenderRegion::styleDidChange you can call checkRegionStyle I think
(doing whatever setup you need to in order to selector check), and then set a
bit on RenderRegion instead of inside the RenderStyle itself.