[webkit-reviews] review granted: [Bug 70816] Get rid of optional parameters in the middle in IDLs. : [Attachment 112332] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 70816: Get rid of optional parameters in the middle in IDLs.
https://bugs.webkit.org/show_bug.cgi?id=70816

Attachment 112332: Patch
https://bugs.webkit.org/attachment.cgi?id=112332&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112332&action=review


Did you run ./Tool/Scripts/run-bindings-tests ?  You might need to update the
expected results.

> Source/WebCore/page/DOMWindow.idl:218
> -	   [DoNotCheckDomainSecurity, Custom] void postMessage(in
SerializedScriptValue message, in [Optional] Array messagePorts, in DOMString
targetOrigin)
> +	   [DoNotCheckDomainSecurity, Custom] void postMessage(in
SerializedScriptValue message, in DOMString targetOrigin)
>	       raises(DOMException);
> -	   [DoNotCheckDomainSecurity, Custom] void webkitPostMessage(in
SerializedScriptValue message, in [Optional] Array transferList, in DOMString
targetOrigin)
> +	   [DoNotCheckDomainSecurity, Custom] void postMessage(in
SerializedScriptValue message, in Array messagePorts, in DOMString
targetOrigin)
> +	       raises(DOMException);

This is being discussed in the working group, but I see that you're not
changing behavior.

> LayoutTests/fast/canvas/canvas-putImageData-expected.txt:147
> -PASS context.putImageData({}, 0, 0) threw exception Error:
TYPE_MISMATCH_ERR: DOM Exception 17.
> +PASS context.putImageData({}, 0, 0) threw exception TypeError: Type error.

Interesting.  I didn't know these were different.  This looks like an OK
behavior change.