[webkit-reviews] review denied: [Bug 70299] Implement legacy text check emulation in unified text check interface. : [Attachment 111724] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 25 10:02:02 PDT 2011


MORITA Hajime <morrita at google.com> has denied Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 70299: Implement legacy text check emulation in unified text check
interface.
https://bugs.webkit.org/show_bug.cgi?id=70299

Attachment 111724: Patch
https://bugs.webkit.org/attachment.cgi?id=111724&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
The code look good in general. in test, could you use unit testing framework if
possible ?
It makes the test expectation readable.
You can see an example in existing tests like:
http://trac.webkit.org/browser/trunk/LayoutTests/editing/spelling/spelling-inse
rt-html.html for example.


More information about the webkit-reviews mailing list