[webkit-reviews] review granted: [Bug 70755] Merge endOfLine with logicalEndOfLine and startOfLine with logicalStartOfLine : [Attachment 112250] Fixed per comments

[bugzilla-daemon at webkit.org]

Chang Shu <cshu at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 70755: Merge endOfLine with logicalEndOfLine and startOfLine with
logicalStartOfLine
https://bugs.webkit.org/show_bug.cgi?id=70755

Attachment 112250: Fixed per comments
https://bugs.webkit.org/attachment.cgi?id=112250&action=review

------- Additional Comments from Chang Shu <cshu at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112250&action=review


looks good to me.

> Source/WebCore/editing/visible_units.cpp:453
> -    } else if (endBox->isInlineTextBox() && endNode->isTextNode()) {
> -	   InlineTextBox* endTextBox = static_cast<InlineTextBox *>(endBox);
> -	   int endOffset = endTextBox->start();
> -	   if (!endTextBox->isLineBreak())
> -	       endOffset += endTextBox->len();
> -	   pos = Position(static_cast<Text*>(endNode), endOffset);
> -    } else
> +    else if (endBox->isInlineTextBox() && endNode->isTextNode())
> +	   pos = Position(static_cast<Text*>(endNode),
toInlineTextBox(endBox)->caretMaxOffset());
> +    else

I trust you they are equivalent. :)