[webkit-reviews] review granted: [Bug 66664] [Qt][WK2] Add the animations on the ViewportInteractionEngine : [Attachment 112338] proposed patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 66664: [Qt][WK2] Add the animations on the ViewportInteractionEngine
https://bugs.webkit.org/show_bug.cgi?id=66664

Attachment 112338: proposed patch
https://bugs.webkit.org/attachment.cgi?id=112338&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112338&action=review


Great work!

Even if we later decide to not use QScroller, most of this code is reusable, so
r=me

> Source/WebKit2/UIProcess/qt/QtPinchGestureRecognizer.cpp:99
> +		  
m_viewportInteractionEngine->pinchGestureStarted(computeTouchCenter(point1,
point2));

I would like a follow up on this.