[webkit-reviews] review denied: [Bug 70491] Add mechanisms to notify WebCore of showing and dismissing context menu : [Attachment 112334] updated patch with chromium + gtk port changes.

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied chandra shekar vallala
<chandra.vallala at motorola.com>'s request for review:
Bug 70491: Add mechanisms to notify WebCore of showing and dismissing context
menu
https://bugs.webkit.org/show_bug.cgi?id=70491

Attachment 112334: updated patch with chromium + gtk port changes.
https://bugs.webkit.org/attachment.cgi?id=112334&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112334&action=review


I'd say r- due to various nits. How about win, mac, qt, etc...?

> Source/WebCore/ChangeLog:7
> +	   Reviewed by NOBODY (OOPS!).

This line should appear before the description and blank lines before and
after.

> Source/WebCore/ChangeLog:9
> +	   No new tests. (OOPS!)

Please remove this line or explain why this change can't be tested.

> Source/WebKit/chromium/ChangeLog:8
> +	   Reviewed by NOBODY (OOPS!).

Again this line should appear above the description and a blank line.

> Source/WebKit/chromium/public/WebView.h:328
> +    virtual void didCloseContextMenu() { }

Shouldn't this be a pure virtual function?

> Source/WebKit/gtk/ChangeLog:8
> +	   Reviewed by NOBODY (OOPS!).

Ditto.

> Source/WebKit/gtk/webkit/webkitwebview.cpp:320
> +    HitTestResult result = controller->hitTestResult();
> +
> +    Node* node = result.innerNonSharedNode();
> +    if (!node)
> +	   return;

Why do we need to hit-test?

> Source/WebKit/gtk/webkit/webkitwebview.cpp:321
> +    sleep(1000);

Where did this sleep(1000); come from?