[webkit-reviews] review granted: [Bug 70726] Web Inspector: fix empty line handling in source maps. : [Attachment 112186] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 70726: Web Inspector: fix empty line handling in source maps.
https://bugs.webkit.org/show_bug.cgi?id=70726

Attachment 112186: Patch
https://bugs.webkit.org/attachment.cgi?id=112186&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112186&action=review


> Source/WebCore/inspector/front-end/CompilerSourceMapping.js:161
> +		       stringCharIterator.next();

I think you need to check hasNext() here and probably at line 156.

> LayoutTests/inspector/debugger/compiler-source-mapping.html:81
> +		   "mappings":"AAAA;;;CACA",

Add test for comma?