[webkit-reviews] review granted: [Bug 70529] [Qt][WK2] Remove QtWidgets dependency in MiniBrowser : [Attachment 112322] patch for review. - save touch mocking.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 25 05:26:26 PDT 2011


Simon Hausmann <hausmann at webkit.org> has granted Zeno Albisser
<zeno.albisser at nokia.com>'s request for review:
Bug 70529: [Qt][WK2] Remove QtWidgets dependency in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=70529

Attachment 112322: patch for review. - save touch mocking.
https://bugs.webkit.org/attachment.cgi?id=112322&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112322&action=review


r=me

> Tools/ChangeLog:9
> +	   Change BrowserWindow to derive from QSGView instead of
> +	   QMainWindow. QSGView is used as a top level window that

We're going to have the land this before Friday, otherwise the patch will need
work to adapt to the QSG* -> QQuick* renaming.

> Tools/MiniBrowser/qt/main.cpp:33
> +#include <QDir>

This seems unnecessary?


More information about the webkit-reviews mailing list