[webkit-reviews] review granted: [Bug 70520] [Qt][WK2] Remove redundant setPageIsVisible() API : [Attachment 112192] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 25 01:39:01 PDT 2011


Simon Hausmann <hausmann at webkit.org> has granted Zalan Bujtas
<zbujtas at gmail.com>'s request for review:
Bug 70520: [Qt][WK2] Remove redundant setPageIsVisible() API
https://bugs.webkit.org/show_bug.cgi?id=70520

Attachment 112192: Patch
https://bugs.webkit.org/attachment.cgi?id=112192&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112192&action=review


r=me

> Source/WebKit2/UIProcess/DrawingAreaProxy.h:-80
> -    virtual void setPageIsVisible(bool isVisible) = 0;

I guess visibilityDidChange() could be made pure virtual now, as suggested in
r76157


More information about the webkit-reviews mailing list