[webkit-reviews] review granted: [Bug 70698] Removed SharedUChar and tightened language around its previous uses : [Attachment 112269] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 24 16:16:02 PDT 2011


David Levin <levin at chromium.org> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 70698: Removed SharedUChar and tightened language around its previous uses
https://bugs.webkit.org/show_bug.cgi?id=70698

Attachment 112269: Patch
https://bugs.webkit.org/attachment.cgi?id=112269&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I think this will break the Win build because it has its own list of exports at
Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def

but I don't see references to these functions in there. Some thing to watch
when you check in.


More information about the webkit-reviews mailing list