[webkit-reviews] review granted: [Bug 70057] [chromium] Refactor LayerRendererChromium drawing code. : [Attachment 112244] added updateCompositorResources for replica

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Shawn Singh
<shawnsingh at chromium.org>'s request for review:
Bug 70057: [chromium] Refactor LayerRendererChromium drawing code.
https://bugs.webkit.org/show_bug.cgi?id=70057

Attachment 112244: added updateCompositorResources for replica
https://bugs.webkit.org/attachment.cgi?id=112244&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112244&action=review


R=me

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:395
> +	  
TRACE_EVENT("LayerRendererChromium::drawLayersInternal::drawLayersOntoRenderSur
faces", this, 0);

nit: since this is now a helper function you can just move the trace into the
function body and avoid having to make this extra scope

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:402
> +    // For masks and repliacs however, we may still need to check them here.


typo 'repliacs' -> 'replicas'