[webkit-reviews] review granted: [Bug 70747] check-webkit-style complains about WEBKIT_EXPORT in test/WebUnitTests.h : [Attachment 112221] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 24 11:56:54 PDT 2011


Tony Chang <tony at chromium.org> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 70747: check-webkit-style complains about WEBKIT_EXPORT in
test/WebUnitTests.h
https://bugs.webkit.org/show_bug.cgi?id=70747

Attachment 112221: Patch
https://bugs.webkit.org/attachment.cgi?id=112221&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112221&action=review


> Tools/Scripts/webkitpy/style/checkers/cpp.py:1607
>		     'WEBKIT_EXPORT should only appear in the chromium public
directory.')

Nit: Do we want to update the error text?


More information about the webkit-reviews mailing list