[webkit-reviews] review granted: [Bug 70065] IndexedDB: Throw DATA_ERR on invalid keys, remove null key support : [Attachment 111087] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 70065: IndexedDB: Throw DATA_ERR on invalid keys, remove null key support
https://bugs.webkit.org/show_bug.cgi?id=70065

Attachment 111087: Patch
https://bugs.webkit.org/attachment.cgi?id=111087&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111087&action=review


> Source/WebCore/storage/IDBKeyRange.h:56
> +	 return lowerBound(bound, false, ec);

Nit: WebKit style prefers using enums rather than bools for arguments.	It
makes it more clear at the caller what the second param is.  Since the code was
already using bools, this is just a suggestion for a future cleanup.  This
would only apply to the private methods, not the idl methods.