[webkit-reviews] review granted: [Bug 70656] [chromium] Make accelerated drawing work with threaded compositing : [Attachment 112195] proposed patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Alok Priyadarshi
<alokp at chromium.org>'s request for review:
Bug 70656: [chromium] Make accelerated drawing work with threaded compositing
https://bugs.webkit.org/show_bug.cgi?id=70656

Attachment 112195: proposed patch
https://bugs.webkit.org/attachment.cgi?id=112195&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112195&action=review


R=me

> Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:57
> +    SkCanvas* Initialize(GraphicsContext3D*, TextureAllocator*,
ManagedTexture*);

lowercase 'initialize' please

> Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:79
> +SkCanvas* FrameBuffer::Initialize(GraphicsContext3D* context,
TextureAllocator* allocator, ManagedTexture* texture)

the function name should be lowercase

> Source/WebCore/platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:203
> +    FrameBuffer buffer;
> +    SkCanvas* canvas = buffer.Initialize(context, allocator, texture);

This means we'll create a new FBO every time we upload a tile, right? That
sounds like a good plan to start but we'll probably want to cache this somehow
in the future, correct?