[webkit-reviews] review denied: [Bug 70718] Web Inspector: Debugger fails when there is an invalid watch expression. : [Attachment 112189] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 70718: Web Inspector: Debugger fails when there is an invalid watch
expression.
https://bugs.webkit.org/show_bug.cgi?id=70718

Attachment 112189: Patch
https://bugs.webkit.org/attachment.cgi?id=112189&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112189&action=review


> Source/WebCore/inspector/front-end/ConsoleView.js:576
> +	   if (WebInspector.panels.scripts.paused &&
WebInspector.panels.scripts.isCallFrameSelected()) {

I'd suggest that we maintain the following invariant: whenever paused === true,
there is a call frame selected.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:478
> +	   if (selectedCallFrame)

Let's fail in case there is not selected callframe.