[webkit-reviews] review denied: [Bug 70600] Web Inspector: [Extensions API] allow extensions to specify script to be injected on reload : [Attachment 112200] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 70600: Web Inspector: [Extensions API] allow extensions to specify script
to be injected on reload
https://bugs.webkit.org/show_bug.cgi?id=70600

Attachment 112200: patch
https://bugs.webkit.org/attachment.cgi?id=112200&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112200&action=review


> Source/WebCore/inspector/InspectorPageAgent.cpp:342
> +    m_pendingScriptToEvaluateOnLoadOnce = optionalScriptToEvaluateOnLoad ?
*optionalScriptToEvaluateOnLoad : "";

You don't need this pending script.

> Source/WebCore/inspector/InspectorPageAgent.cpp:584
> +    ScriptState* scriptState = 0; // Initialize lazily, as
mainWorldScriptState() will create one if missing.

Early return in case of no front-end?