[webkit-reviews] review denied: [Bug 42546] WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate : [Attachment 111958] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (:aroben) <aroben at apple.com> has denied Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 42546: WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
https://bugs.webkit.org/show_bug.cgi?id=42546

Attachment 111958: Patch
https://bugs.webkit.org/attachment.cgi?id=111958&action=review

------- Additional Comments from Adam Roben (:aroben) <aroben at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=111958&action=review


> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:137
>  enum {
> +    WKBundlePagePolicyActionIgnore,
>      WKBundlePagePolicyActionPassThrough,
>      WKBundlePagePolicyActionUse

I believe this breaks ABI compatibility with Safari 5.1 (i.e., will break
nightly builds).

> Tools/ChangeLog:17
> +	   waitToPolicyDelegate. We need to ignore the navigation action if we
> +	   are not in permissive mode. This has not caused a problem with
> +	   waitToPolicyDelegate because with that we explicitly stop testing
> +	   via notifyDone and do not send any request after that.

What is "waitToPolicyDelegate"?

> LayoutTests/platform/wk2/Skipped:564
>  # WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
>  # <https://bugs.webkit.org/show_bug.cgi?id=42546>
> -fast/loader/javascript-url-hierarchical-execution.html
> -fast/loader/onload-policy-ignore-for-frame.html
> -fast/loader/reload-policy-delegate.html
> -http/tests/misc/policy-delegate-called-twice.html
> -http/tests/misc/redirect-to-external-url.html
> -http/tests/security/feed-urls-from-remote.html
> +#fast/loader/javascript-url-hierarchical-execution.html
> +#fast/loader/onload-policy-ignore-for-frame.html
> +#fast/loader/reload-policy-delegate.html
> +#http/tests/misc/policy-delegate-called-twice.html
> +#http/tests/misc/redirect-to-external-url.html
> +#http/tests/security/feed-urls-from-remote.html

You should delete the lines rather than just commenting them out.