[webkit-reviews] review denied: [Bug 70721] Web Inspector: [Styles] Adding a new style rule breaks things : [Attachment 112184] [PATCH] Suggested fix

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 70721: Web Inspector: [Styles] Adding a new style rule breaks things
https://bugs.webkit.org/show_bug.cgi?id=70721

Attachment 112184: [PATCH] Suggested fix
https://bugs.webkit.org/attachment.cgi?id=112184&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112184&action=review


> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1358
> +    get isBlank()

make it a function please.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1387
> +	   if (this.isBlank)

Could you move this check to the top and make it a guard? Also putting a FIXME
suggesting re-creating object would be great.

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1395
> +	   if (this.isBlank)

Please convert to the guard.