[webkit-reviews] review granted: [Bug 69343] [GTK] Initial implementation of back forward list for WebKit2 GTK+ API : [Attachment 111959] New patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 69343: [GTK] Initial implementation of back forward list for WebKit2 GTK+
API
https://bugs.webkit.org/show_bug.cgi?id=69343

Attachment 111959: New patch
https://bugs.webkit.org/attachment.cgi?id=111959&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111959&action=review


Okay! We should later use a similar helper to the Mac port for dealing with the
empty string -> null return. I think that would cut down on the code and codify
this way of writing the API.

> Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardListItem.cpp:104
> + * Returns: the URI of @back_forward_list_item or %NULL.

Do you mind appending "when the URI is empty" here?

> Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardListItem.cpp:123
> + * Returns: the page title of @back_forward_list_item or %NULL.

...and "when the title is empty" here?

> Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardListItem.cpp:144
> + * Returns: the original URI of @back_forward_list_item or %NULL.

...and "when the URI is empty" here?