[webkit-reviews] review denied: [Bug 70320] step=.5 should be considered valid in <input type="number" step=".5"> : [Attachment 111940] Fix for Incorporating the change in spec as specified.

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Sachin Puranik
<jcqt43 at motorola.com>'s request for review:
Bug 70320: step=.5 should be considered valid in <input type="number"
step=".5">
https://bugs.webkit.org/show_bug.cgi?id=70320

Attachment 111940: Fix for Incorporating the change in spec as specified.
https://bugs.webkit.org/attachment.cgi?id=111940&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111940&action=review


> LayoutTests/fast/forms/input-step-as-double.html:4
> +<link rel="stylesheet" href="../../fast/js/resources/js-test-style.css">

This line is not needed.  It is inserted automatically by js-test-pre.js.

> LayoutTests/fast/forms/input-step-as-double.html:9
> +<p id="description"></p>
> +<div id="console"></div>

These two elements are not needed.  They are created automatically.

> LayoutTests/fast/forms/input-step-as-double.html:10
> +<script src="script-tests/input-step-as-double.js"></script>

Do not make a separated .js file. Please embed it into here.

> LayoutTests/fast/forms/script-tests/input-valueasnumber-number.js:-34
> -shouldBeTrue('isNaN(valueAsNumberFor(".2"))');

We should have a test for valueAsNumberFor(".") instead.