[webkit-reviews] review granted: [Bug 70698] Removed some String misfeatures : [Attachment 112118] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted  review:
Bug 70698: Removed some String misfeatures
https://bugs.webkit.org/show_bug.cgi?id=70698

Attachment 112118: Patch
https://bugs.webkit.org/attachment.cgi?id=112118&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112118&action=review


Please delete
http://trac.webkit.org/browser/trunk/Source/JavaScriptCore/wtf/CrossThreadRefCo
unted.h as well since this was the only thing that used it. Hurray! (I really
disliked that class.)

And remove the changes that you're doing in the other patch.


You could make the change log more factual and spare my feelings now by just
making the title "Remove BufferShared." and really it isn't needed anymore I
think it sufficient but whatever you want for the description.

> Source/JavaScriptCore/wtf/text/StringImpl.h:307
> +    PassRefPtr<StringImpl> isolatedCopy() const;

I like the name isolatedCopy. Thanks. (I struggled with naming here and failed
and still have an open bug on the naming which you are fixing.)