[webkit-reviews] review denied: [Bug 70693] [Qt][WK2] QDesktopWebView and QTouchWebView should be declared in the meta type system. : [Attachment 112109] patch for review.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 23 12:49:16 PDT 2011


Tor Arne Vestbø <vestbo at webkit.org> has denied Zeno Albisser
<zeno.albisser at nokia.com>'s request for review:
Bug 70693: [Qt][WK2] QDesktopWebView and QTouchWebView should be declared in
the meta type system.
https://bugs.webkit.org/show_bug.cgi?id=70693

Attachment 112109: patch for review.
https://bugs.webkit.org/attachment.cgi?id=112109&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
Yepp, this is the place we should do it. But it should be
QML_DECLARE_TYPE(QTouchWebView), to get the pointer automatically and cover the
list-usecase.

http://doc.qt.nokia.com/4.7-snapshot/qdeclarativeengine.html#QML_DECLARE_TYPE


More information about the webkit-reviews mailing list