[webkit-reviews] review denied: [Bug 70685] REGRESSION(r38617): StyleBase::useStrictParsing() always returns true. : [Attachment 112098] Proposed patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Andreas Kling <kling at webkit.org>'s
request for review:
Bug 70685: REGRESSION(r38617): StyleBase::useStrictParsing() always returns
true.
https://bugs.webkit.org/show_bug.cgi?id=70685

Attachment 112098: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=112098&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
It is rather random that the argument-free CSSMutableStyleDeclaration
constructor gives you non-strict parsing while the others give you strict
parsing. The original code has logic in it (inherit the strictness if possible)
though obviously it is now broken.

It also seems strange that parsing of the media rules doesn't inherit the
strictness of the containing style sheet.

Unless those can somehow be explained away, it might be better to actually fix
this. I'm sure it can be done without StyleBase virtuals though...