[webkit-reviews] review granted: [Bug 70672] Make relayout-nested-positioned-elements-crash.html more reliable : [Attachment 112079] Patch

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 70672: Make relayout-nested-positioned-elements-crash.html more reliable
https://bugs.webkit.org/show_bug.cgi?id=70672

Attachment 112079: Patch
https://bugs.webkit.org/attachment.cgi?id=112079&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112079&action=review


I see this as an improvement, but I have a few comments.

> LayoutTests/ChangeLog:9
> +	   Change the test to use the Javascript test framework.
> +	   Ensure the element has the correct style in the final state.

Any comment on why or when it was unreliable?

>
LayoutTests/fast/block/positioning/relayout-nested-positioned-elements-crash.ht
ml:17
> +description("This tests that we don't cause an assertion failure on relayout
of nested positioned elements. This test pass if we don't cause an assertion
failure.");

and the element has the correct style in the final state. ?