[webkit-reviews] review granted: [Bug 61344] --webkit-visual-word does not work in multi-line : [Attachment 112036] patch w/ layout test

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 61344: --webkit-visual-word does not work in multi-line
https://bugs.webkit.org/show_bug.cgi?id=61344

Attachment 112036: patch w/ layout test
https://bugs.webkit.org/attachment.cgi?id=112036&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112036&action=review


> Source/WebCore/editing/visible_units.cpp:1492
> +	       InlineBox* boxInPreviousNode;
> +	       int ignoredCaretOffset;
> +	       pos.getInlineBoxAndOffset(DOWNSTREAM, boxInPreviousNode,
ignoredCaretOffset);
> +
> +	       if (boxInPreviousNode)
> +		   return boxInPreviousNode->root();

Please use RenderedPosition to obtain the root inline box.

> Source/WebCore/editing/visible_units.cpp:1518
> +	       InlineBox* boxInNextNode;
> +	       int ignoredCaretOffset;
> +	       pos.getInlineBoxAndOffset(DOWNSTREAM, boxInNextNode,
ignoredCaretOffset);
> +
> +	       if (boxInNextNode)
> +		   return boxInNextNode->root();

Ditto.