[webkit-reviews] review granted: [Bug 69996] DFG should have inlining : [Attachment 112050] the patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 69996: DFG should have inlining
https://bugs.webkit.org/show_bug.cgi?id=69996

Attachment 112050: the patch
https://bugs.webkit.org/attachment.cgi?id=112050&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=112050&action=review


r=me

> Source/JavaScriptCore/dfg/DFGJITCompiler32_64.cpp:482
> +	   store32(Imm32(JSValue::CellTag),
tagFor((VirtualRegister)(inlineCallFrame->stackOffset +
RegisterFile::ScopeChain)));

So much sadness :-/

> Source/JavaScriptCore/runtime/Heuristics.cpp:32
> -#define ENABLE_RUN_TIME_HEURISTICS 0
> +#define ENABLE_RUN_TIME_HEURISTICS 1

Do we want these on by default?