[webkit-reviews] review denied: [Bug 70661] Remove unnecessary and confusing RetainPtr from ImaegBufferCG::copyImage : [Attachment 112046] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 70661: Remove unnecessary and confusing RetainPtr from
ImaegBufferCG::copyImage
https://bugs.webkit.org/show_bug.cgi?id=70661

Attachment 112046: Patch
https://bugs.webkit.org/attachment.cgi?id=112046&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=112046&action=review


It looks like MediaPlayerPrivateAVFoundationObjC::createImageForTimeInRect()
may have a similar leak.

> Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:209
> +    // BitmapImage takes ownnership of the image

I think this also needs to be cleaned up. BitmapImage should not take
ownership, just retain itself.