[webkit-reviews] review granted: [Bug 69986] Web Inspector: Make indent configurable : [Attachment 112037] "8 spaces" option added. Use <select> instead of <input type=radio>

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Nikita Vasilyev
<me at elv1s.ru>'s request for review:
Bug 69986: Web Inspector: Make indent configurable
https://bugs.webkit.org/show_bug.cgi?id=69986

Attachment 112037: "8 spaces" option added. Use <select> instead of <input
type=radio>
https://bugs.webkit.org/attachment.cgi?id=112037&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112037&action=review


Code looks good, thanks for doing this. Please remove the tests OOPS line and
attach a screenshot so that I could cq+.

> Source/WebCore/ChangeLog:10
> +	   No new tests. (OOPS!)

Please remove this line.

> Source/WebCore/inspector/front-end/SettingsScreen.js:140
> +	       if (settingValue == option[0])

use ===