[webkit-reviews] review requested: [Bug 69986] Web Inspector: Make indent configurable : [Attachment 112037] "8 spaces" option added. Use <select> instead of <input type=radio>

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 21 15:45:18 PDT 2011


Nikita Vasilyev <me at elv1s.ru> has asked  for review:
Bug 69986: Web Inspector: Make indent configurable
https://bugs.webkit.org/show_bug.cgi?id=69986

Attachment 112037: "8 spaces" option added. Use <select> instead of <input
type=radio>
https://bugs.webkit.org/attachment.cgi?id=112037&action=review

------- Additional Comments from Nikita Vasilyev <me at elv1s.ru>
(In reply to comment #17)
> > 
> > Are you suggesting to add one more <input type=radio>?
> 
> You could do <select> as in "Open links in..." setting.

"Open links in..." select uses WebInspector.HandlerRegistry... I've spent
almost couple hours scratching my head trying to figure out how to it make my
select work with it. Then I've given up and just made a _createSelectSetting
method that looks very similar to _createRadioSetting.


More information about the webkit-reviews mailing list