[webkit-reviews] review granted: [Bug 70654] Rename WKProcessCluster to WKProcessGroup : [Attachment 112030] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 21 15:20:16 PDT 2011


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 70654: Rename WKProcessCluster to WKProcessGroup
https://bugs.webkit.org/show_bug.cgi?id=70654

Attachment 112030: Patch
https://bugs.webkit.org/attachment.cgi?id=112030&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=112030&action=review


> Source/WebKit2/UIProcess/API/mac/WKProcessGroup.h:37
> +- (id)init;

You don't need to declare -init in the header.

> Source/WebKit2/UIProcess/API/mac/WKProcessGroup.mm:56
> +    _data = [[WKProcessClusterData alloc] init];

Can't we use 'retain' properties for this?


More information about the webkit-reviews mailing list