[webkit-reviews] review granted: [Bug 70637] webkitpy: Teach NRWT about the EFL port : [Attachment 112013] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 21 13:53:40 PDT 2011


Eric Seidel <eric at webkit.org> has granted Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 70637: webkitpy: Teach NRWT about the EFL port
https://bugs.webkit.org/show_bug.cgi?id=70637

Attachment 112013: Patch
https://bugs.webkit.org/attachment.cgi?id=112013&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112013&action=review


Seems reasonable.

> Tools/Scripts/webkitpy/layout_tests/port/efl.py:45
> +	   self._version = self.port_name

This seems odd.  Why is this needed?


More information about the webkit-reviews mailing list