[webkit-reviews] review denied: [Bug 70637] webkitpy: Teach NRWT about the EFL port : [Attachment 112010] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Leandro Pereira
<leandro at profusion.mobi>'s request for review:
Bug 70637: webkitpy: Teach NRWT about the EFL port
https://bugs.webkit.org/show_bug.cgi?id=70637

Attachment 112010: Patch
https://bugs.webkit.org/attachment.cgi?id=112010&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=112010&action=review


LGTM, except it can't work as-is due to the factory.py typo.

> Tools/Scripts/webkitpy/layout_tests/port/efl.py:70
> +	   return static_path if os.path.isfile(static_path) else dyn_path

This should use self._filesystem.exists instead.

> Tools/Scripts/webkitpy/layout_tests/port/factory.py:111
> +	       maker = qt.EflPort

You mean efl.EflPort