[webkit-reviews] review denied: [Bug 70505] [GTK] [WK2] Memory leaks in WebContextGtk.cpp : [Attachment 111792] Fix memory leaks

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Sudarsana Nagineni
<naginenis at gmail.com>'s request for review:
Bug 70505: [GTK] [WK2] Memory leaks in WebContextGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=70505

Attachment 111792: Fix memory leaks
https://bugs.webkit.org/attachment.cgi?id=111792&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111792&action=review


Nice catch! Just a small suggestion below.

> Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp:51
> +    return WTF::String::fromUTF8(databaseDirectory.get());

I know this was still an issue before, but do you mind using filenameToString
from FileSystemGtk instead of fromUTF8 here? It's more correct.

> Source/WebKit2/UIProcess/gtk/WebContextGtk.cpp:63
> +    return WTF::String::fromUTF8(storageDirectory.get());

Ditto.