[webkit-reviews] review denied: [Bug 70620] [chromium] Route Console::time and Console::timeEnd to trace_event : [Attachment 111986] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Nat Duca
<nduca at chromium.org>'s request for review:
Bug 70620: [chromium] Route Console::time and Console::timeEnd to trace_event
https://bugs.webkit.org/show_bug.cgi?id=70620

Attachment 111986: Patch
https://bugs.webkit.org/attachment.cgi?id=111986&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111986&action=review


What is the story behind the change? We tend to do it the other way (push
information into the Web Inspector front-end through the WebCore). r- for not
compiling in any case.

> Source/WebCore/page/Console.cpp:311
> +#if PLATFORM(CHROMIUM)

I really don't like these. But I don't see a better way of handling it here.

> Source/WebCore/page/Console.cpp:312
> +    if (PlatformSupport::isTraceEventEnabledForCategory("webcore.console"))

I don't see this method on ToT. See compile failures on ews.