[webkit-reviews] review granted: [Bug 62395] IndexedDB: objectStore.transaction property should be readonly : [Attachment 111994] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 21 12:48:03 PDT 2011


Adam Barth <abarth at webkit.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 62395: IndexedDB: objectStore.transaction property should be readonly
https://bugs.webkit.org/show_bug.cgi?id=62395

Attachment 111994: Patch
https://bugs.webkit.org/attachment.cgi?id=111994&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111994&action=review


> Source/WebCore/storage/IDBObjectStore.cpp:71
> +PassRefPtr<IDBTransaction> IDBObjectStore::transaction() const

This should just be a raw pointer.

> Source/WebCore/storage/IDBObjectStore.idl:34
> +	   readonly attribute IDBTransaction transaction;

I assume this is in the spec.


More information about the webkit-reviews mailing list