[webkit-reviews] review denied: [Bug 70491] Add mechanisms to notify WebCore of showing and dismissing context menu : [Attachment 111964] patch for WebCore changes.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 21 11:18:30 PDT 2011
Ryosuke Niwa <rniwa at webkit.org> has denied chandra shekar vallala
<chandra.vallala at motorola.com>'s request for review:
Bug 70491: Add mechanisms to notify WebCore of showing and dismissing context
menu
https://bugs.webkit.org/show_bug.cgi?id=70491
Attachment 111964: patch for WebCore changes.
https://bugs.webkit.org/attachment.cgi?id=111964&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111964&action=review
> Source/WebCore/page/EventHandler.cpp:2264
> + m_frame->selection()->setCaretBlinkingSuspended(true);
This patch shouldn't be adding a bug fix. Instead, you should add an empty stub
functions that are called by each port.
More information about the webkit-reviews
mailing list