[webkit-reviews] review denied: [Bug 66851] Fix CSSPrimitiveValue::cssText() to use StringBuilder : [Attachment 111969] Fix CSSPrimitiveValue::cssText() to use StringBuilder and add two StringBuilder append overload

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 21 08:47:19 PDT 2011


Andreas Kling <kling at webkit.org> has denied Oliver Varga
<voliver at inf.u-szeged.hu>'s request for review:
Bug 66851: Fix CSSPrimitiveValue::cssText() to use StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=66851

Attachment 111969: Fix CSSPrimitiveValue::cssText() to use StringBuilder and
add two StringBuilder append overload
https://bugs.webkit.org/attachment.cgi?id=111969&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
You need to move the huge functions in StringBuilder.h to a cpp file to prevent
them from being inlined at least once per compilation unit that calls them.


More information about the webkit-reviews mailing list