[webkit-reviews] review granted: [Bug 70523] Web Inspector: get rid of View::hide, View::set visible, View::attach. : [Attachment 111966] [Patch] Review comments addressed.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 21 08:50:52 PDT 2011
Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 70523: Web Inspector: get rid of View::hide, View::set visible,
View::attach.
https://bugs.webkit.org/show_bug.cgi?id=70523
Attachment 111966: [Patch] Review comments addressed.
https://bugs.webkit.org/attachment.cgi?id=111966&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111966&action=review
> Source/WebCore/inspector/front-end/View.js:175
> + if (childIndex < 0) {
Could be _assert
More information about the webkit-reviews
mailing list