[webkit-reviews] review denied: [Bug 70600] Web Inspector: [Extensions API] allow extensions to specify script to be injected on reload : [Attachment 111944] patch (fixed style)

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 70600: Web Inspector: [Extensions API] allow extensions to specify script
to be injected on reload
https://bugs.webkit.org/show_bug.cgi?id=70600

Attachment 111944: patch (fixed style)
https://bugs.webkit.org/attachment.cgi?id=111944&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111944&action=review


> Source/WebCore/inspector/Inspector.json:164
> +		       { "name": "removeOnReload", "type": "boolean",
"optional": true }

"persistent" + docs?

> Source/WebCore/inspector/front-end/ExtensionAPI.js:497
> +	   else if (typeof optionsOrUserAgent === "string") {

This will never compile.

> Source/WebCore/inspector/front-end/WorkersSidebarPane.js:81
> +	   if (!enabled === !this._fakeWorkersScriptIdentifier)

Could you disable checkbox instead?