[webkit-reviews] review denied: [Bug 69781] [WK2] Add a C API to inspect injected bundle path associated with a WKContextRef : [Attachment 111943] Patch contains new API WKContextGetInjectedBundlePath to inspect injected bundle path associated with a WKContextRef

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 21 05:10:42 PDT 2011


Andreas Kling <kling at webkit.org> has denied  review:
Bug 69781: [WK2] Add a C API to inspect injected bundle path associated with a
WKContextRef
https://bugs.webkit.org/show_bug.cgi?id=69781

Attachment 111943: Patch contains new API WKContextGetInjectedBundlePath to
inspect injected bundle path associated with a WKContextRef
https://bugs.webkit.org/attachment.cgi?id=111943&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=111943&action=review


Please set r? if you want a patch to be reviewed. :)

> Source/WebKit2/UIProcess/API/C/WKContext.cpp:67
> +WKStringRef WKContextGetInjectedBundlePath(WKContextRef contextRef)
> +{
> +    return toCopiedAPI(toImpl(contextRef)->injectedBundlePath());
> +}

This should be called WKContextCopyInjectedBundlePath since it returns a copy.


More information about the webkit-reviews mailing list