[webkit-reviews] review requested: [Bug 67277] REGRESSION (r94132): broke fast/loader/location-port.html on GTK : [Attachment 111947] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 21 05:08:37 PDT 2011


Devdatta <pwjd73 at motorola.com> has asked  for review:
Bug 67277: REGRESSION (r94132): broke fast/loader/location-port.html on GTK
https://bugs.webkit.org/show_bug.cgi?id=67277

Attachment 111947: Patch
https://bugs.webkit.org/attachment.cgi?id=111947&action=review

------- Additional Comments from Devdatta <pwjd73 at motorola.com>
This seems to be an issue with libSoup API. If port is 0, it is not explicitly
specified in SoupURI.
<http://maemo.org/api_refs/5.0/5.0-final/libsoup-2.4/libsoup-24-SoupURI.html#so
up-uri-set-port>

Hence adding an explicit check for the port before updating ResourceRequest
with SoupMessage fixes this issue.

I have attached the patch for review.


More information about the webkit-reviews mailing list