[webkit-reviews] review canceled: [Bug 69403] [WK2] [GTK] WebKitTestRunner crashes with heap corruption : [Attachment 109753] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 21 05:05:23 PDT 2011


Alejandro G. Castro <alex at igalia.com> has canceled Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 69403: [WK2] [GTK] WebKitTestRunner crashes with heap corruption
https://bugs.webkit.org/show_bug.cgi?id=69403

Attachment 109753: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=109753&action=review

------- Additional Comments from Alejandro G. Castro <alex at igalia.com>
Used the solution of adding the include to the prefix file. I've checked the
option to add an #error in the Platform.h but we are not respecting the rule in
JSC. Currently it is not a problem because those files do not use the DEFINES
in Platform.h, so the code would be a little bit overkill in the my opinion to
be added in this patch. I think we can check it in the future if we find this
situation is common.


More information about the webkit-reviews mailing list