[webkit-reviews] review denied: [Bug 70564] [Chromium] Make root layer always opaque : [Attachment 111875] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 20 17:26:07 PDT 2011


James Robinson <jamesr at chromium.org> has denied Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 70564: [Chromium] Make root layer always opaque
https://bugs.webkit.org/show_bug.cgi?id=70564

Attachment 111875: Patch
https://bugs.webkit.org/attachment.cgi?id=111875&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
I'd rather we set the bit instead of overriding what 'opaque()' returns.  Can
you look at where we set the "NonComposited" bit and call setOpaque() there
instead
(http://google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore
/platform/graphics/chromium/NonCompositedContentHost.cpp&q=setIsNonCompo&exact_
package=chromium&l=45)?


More information about the webkit-reviews mailing list